Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom resolver signals #58

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

custom resolver signals #58

wants to merge 5 commits into from

Conversation

jerch
Copy link
Collaborator

@jerch jerch commented Jul 19, 2020

Shall fix #56.

This is just a proof of concept currently with hacked in signal dispatching for update_dependent.

TODO:

  • apply data aggregation on all resolver parts including handler code
  • find a good way to aggregate data with least mem usage / runtime penalty
  • useful shaping of signal arguments
  • single aggregation signal vs. more fine-grained ones or both

FYI: @mobiware

@coveralls
Copy link

coveralls commented Jul 19, 2020

Pull Request Test Coverage Report for Build 364

  • 26 of 26 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.869%

Totals Coverage Status
Change from base Build 354: 0.08%
Covered Lines: 986
Relevant Lines: 1013

💛 - Coveralls

@jerch
Copy link
Collaborator Author

jerch commented Jan 2, 2022

@mobiware Are you still interested in the signal feature? Ive found another use case with django-solo, which might benefit from update signals (it caches a single instance to reduce db interactions, which ofc would miss updates on the db values without any way to mark the cache entry as outdated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notifications from resolver CF updates
2 participants