Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxLength i18n zh_CN msg can not understand #838

Closed
fei33423 opened this issue Jul 12, 2023 · 3 comments
Closed

maxLength i18n zh_CN msg can not understand #838

fei33423 opened this issue Jul 12, 2023 · 3 comments

Comments

@fei33423
Copy link

fei33423 commented Jul 12, 2023

https://github.com/networknt/json-schema-validator/blob/3ff32ee3fbb1c6287c6dfeda14a8bdeb965ef6c3/src/main/resources/jsv-messages.properties#L24C1-L24C49

maxLength = {0}: may only be {1} characters long

i think should use "must " similar as minLength.
should be

maxLength = {0}: must be at most {1} characters long
minLength = {0}: must be at least {1} characters long

also other i18n should be fix.

@fei33423 fei33423 changed the title maxLength i18n msg is wrong maxLength i18n zh_CN msg can not understand Jul 12, 2023
@fdutton
Copy link
Contributor

fdutton commented Jul 29, 2023

@fei33423 Are you willing to submit a pull request?

@justin-tay
Copy link
Contributor

The maxLength messages were changed to the following

maxLength = {0}: must be at most {1} characters long
minLength = {0}: must be at least {1} characters long
maxLength = {0}: 长度不得超过 {1} 个字符
maxLength = {0}: 长度必须至少为 {1} 个字符

@stevehu
Copy link
Contributor

stevehu commented Jun 3, 2024

@justin-tay Thanks for the confirmation. This issue is closed.

@stevehu stevehu closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants