Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional i18n language(spanish) support related (#847) #1019

Closed
channaveer1 opened this issue Apr 16, 2024 · 8 comments
Closed

Additional i18n language(spanish) support related (#847) #1019

channaveer1 opened this issue Apr 16, 2024 · 8 comments

Comments

@channaveer1
Copy link
Contributor

Hi @stevehu i have new i18n language i.e spanish its urgent for us its in production. can you please provide the access .

@channaveer1 channaveer1 changed the title Additional i18n language(spanish) support related #847 Additional i18n language(spanish) support related (#847) Apr 16, 2024
@channaveer1
Copy link
Contributor Author

Hi @networknt/json-schema-validator Please do the needful at the earliest

@stevehu
Copy link
Contributor

stevehu commented Apr 16, 2024

@channaveer1 What do you need? Do you need to provide a PR? or do you need a new release? Or do you need someone to implement the Spanish i18n?

@channaveer1
Copy link
Contributor Author

channaveer1 commented Apr 16, 2024

@stevehu I need to provide PR. i already implemented spanish i18n i have the code with me. and also we need the release as well at the earliest

@stevehu
Copy link
Contributor

stevehu commented Apr 16, 2024

Then you need to fork the repo, and update the code and issue a PR. You don't need any permission to do so.

@channaveer1
Copy link
Contributor Author

channaveer1 commented Apr 16, 2024

@stevehu I have issued the PR, could you please check and let me know.

#1021

@channaveer1
Copy link
Contributor Author

Please let me know why pipeline is failing for java 8 and if possible please ping me the solution

@justin-tay
Copy link
Contributor

Note that you can easily add support for additional languages by just bundling the relevant properties files with your application as they will be loaded from the classpath. No modifications to the library is actually required.

@stevehu
Copy link
Contributor

stevehu commented May 30, 2024

Close this issue as it is duplicated with #1025

@stevehu stevehu closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants