fix string attribute read #1220
Merged
+54
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabratu
approved these changes
May 17, 2024
bernlu
force-pushed
the
fix/attribute-read-string
branch
from
2fe0243
to
e127175
Compare
bernlu
force-pushed
the
fix/attribute-read-string
branch
from
e127175
to
d6f6c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1187 for std::string (note: this implementation still does not support strings that contain
\n!)vector types are not supported yet; this will require more complex changes (like adding a serialization library).
Fixing the string bug is higher priority though, because string attributes are available in python as well, while vector types are not.