Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas for improving the library #138

Open
kuffmode opened this issue Mar 26, 2024 · 0 comments
Open

Some ideas for improving the library #138

kuffmode opened this issue Mar 26, 2024 · 0 comments

Comments

@kuffmode
Copy link

Hi all,
I've been using Netneurotools for a long time and I have some things you can easily add to improve usability.

  1. Add a citation instruction. I ended up just writing down the GitHub link, but you can add a Cite this repository using a citation.cff file. Here's an example: https://github.com/kuffmode/YANAT/blob/main/CITATION.cff
  2. I would add a check for signed matrices. I remember you can easily pass a signed matrix to communicability that would work and you would end up with a “signed communicability matrix” but as far as I know, negative values don't make sense in these models.
  3. Point plot returns a figure that is unnecessary. I ended up tinkering with it so it returns the ax instead. In this case, people can define their own figures the way they want and embedd a point plot wherever they like. Check function brain_plotter here: https://github.com/kuffmode/OI-and-CMs/blob/main/utils.py#L422

If you prefer, I can do these myself and do a pull request. In any case, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant