-
Notifications
You must be signed in to change notification settings - Fork 67
feat: update netlify-plugin-visual-diff to 1.3.0 and 2.0.0 #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated Packages |
erezrokah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @colbyfayock,
See applitools/netlify-plugin-visual-diff#8 (comment) for the cause of the CI failure.
Also see
Line 370 in 062e1ba
| "compatibility": [ |
|
thanks @ehmicky @erezrokah made the tweaks, lmk if you need anyhting else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo @colbyfayock, looking good.
I have one last issue about the versions I'd like to understand better
|
thanks @erezrokah was able to deprecate 1.4.0 and 1.4.1 as well as updating the compat |
ehmicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @colbyfayock !
erezrokah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @colbyfayock, sorry for the delay to merge.
I updated the PR with 2 distinct build logs for versions 1.3.0 and 2.0.0
Updates the version of the netlify-plugin-visual-diff along with compatibility.
Are you adding a plugin or updating one?
Have you completed the following?
Test plan
https://app.netlify.com/sites/erez-applitools-test/deploys/60d20b3425ba790008c8b81e#L95
https://app.netlify.com/sites/erez-applitools-test/deploys/60d20bd225ba790008c9058d#L81