Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Active Incidents #32

Open
steveoh opened this issue Sep 5, 2017 · 3 comments
Open

Multiple Active Incidents #32

steveoh opened this issue Sep 5, 2017 · 3 comments

Comments

@steveoh
Copy link
Contributor

steveoh commented Sep 5, 2017

- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
duplication of ✅ Up and running
- If the current behavior is a bug, please provide the steps to reproduce.
Create multiple unresolved incidents
- What is the expected behavior?
Only the systems that are affected change and there is no duplication.

image

@RealGrim
Copy link

RealGrim commented Dec 15, 2017

Hello This is happening because you have to indents active at once please disable one, because there are both degraded performance you can just set it so its active on 2 indents like:
affectedsystems = ["API", "CDN"]

If you are still having problems please got to gitter and ask @verythorough!

You can now close this :)

@dracos
Copy link
Contributor

dracos commented Jan 11, 2018

The original issue is a real one. If you have two active incidents for different affected systems (say one is under maintenance, another is degraded performance), then everything gets duplicated in the summary at the top. This is due to the loop over the incidents in partials/systems.html printing a line for each incident for each system, whereas it presuambly needs to work out the 'most severe' of all the incidents applying to that system.

@mariuspana
Copy link

I can confirm this behaviour and that your PR indeed solves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants