fix(security): no token logging on claims parsing errors #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
force-pushed
the
fix/dont_log_token_on_error
branch
from
4ac0d91
to
ff86c3f
Compare
erezrokah
changed the title
ehmicky
reviewed
Jan 28, 2021
ehmicky
approved these changes
Jan 28, 2021
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
This was referenced Jan 3, 2022
This was referenced Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #265.
I
git cherry pickthe commit instead of pushing to that PR since it as opened frommaster.Added a test case for the reported issue.