Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DENO_VERSION_RANGE semver constraint is too loose #575

Open
willsr opened this issue Feb 7, 2024 · 4 comments
Open

DENO_VERSION_RANGE semver constraint is too loose #575

willsr opened this issue Feb 7, 2024 · 4 comments
Labels
type: bug code to address defects in shipped code

Comments

@willsr
Copy link

willsr commented Feb 7, 2024

The DENO_VERSION_RANGE constant is currently set to '^1.37.0' which would satisfy anything from 1.37.0 - 1.99.x.
There is a bug in versions 1.40.x of Deno (See: denoland/deno#22109) which is causing edge functions to fail that rely on certain external modules.

Is it possible to set a fixed Deno version for use in local development? (apart from just manually downloading the desired version into /Users/User/Library/Preferences/netlify - which I can't find any documentation for)

Also is there any way to know the current Deno version running in the Netlify hosted environment?

@willsr willsr added the type: bug code to address defects in shipped code label Feb 7, 2024
@Skn0tt
Copy link
Member

Skn0tt commented Feb 7, 2024

Hey Will! Looking through the code, I don't see a way of fixing the Deno version, no. If i'm understanding denoland/deno#22109 correctly, this doesn't have a super widespread impact. If Deno intends to publish a fix for that this week, then I don't think we can provide a workaround earlier than that. In the meantime, the workaround you mentioned sounds like an "alright enough" solution. Alternatively, you could go into your node_modules directory and manually edit the DENO_VERSION_RANGE variable.

That's not a beautiful workaround, but if Deno publishes a fix this week, then it should be alright. Let me know if this works for you!

@willsr
Copy link
Author

willsr commented Feb 12, 2024

Ok, thanks for responding. Is there a way to to know the current Deno version running in the Netlify hosted environment for edge functions? Or a way to set it manually (similarly to the Node.js version)?

@Skn0tt
Copy link
Member

Skn0tt commented Feb 12, 2024

In the hosted environment, Deno Deploy is managing the version updates - it's not possible to change the version there, no.

@Skn0tt
Copy link
Member

Skn0tt commented Feb 12, 2024

It looks like Deno has completed the mentioned issue - I guess it'll be fixed in their next Patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

2 participants