-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove import { tmpName } from 'tmp-promise'
dependency
#4553
Comments
import { tmpName } from 'tmp-promise'
dependency
@lukasholzer |
Yea this is combined. We never just create a name without creating the dir. So we should replacing that + creating the dir with |
may i work on it |
Sure. Go ahead @muditgaur-1009. Let me know if you come across any issues while setting things up. |
@tinfoil-knight please review i have made the changes |
As this dependency is only used in tests I would prefer to keep it. It has a bunch of convenient functions. I noticed though that |
This dependency is not needed for creating a temp directory as node can do that:
can be converted to:
The text was updated successfully, but these errors were encountered: