Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceConfiguration] General "country" option #47

Open
nemesifier opened this issue Mar 30, 2016 · 0 comments
Open

[DeviceConfiguration] General "country" option #47

nemesifier opened this issue Mar 30, 2016 · 0 comments
Labels
Milestone

Comments

@nemesifier
Copy link
Member

It makes sense to define "country" in the general section, since it doesn't make much sense to define different radios with different country settings.

Therefore I think a similar configuration:

{
    "type": "DeviceConfiguration",
    "general": {
        "country": "EN"
    },
    "radios": [
        {
            "name": "radio0",
            "phy": "phy0",
            "protocol": "802.11n",
            "channel": 140,
            "channel_width": 20
        },
        {
            "name": "radio1",
            "phy": "phy1",
            "protocol": "802.11n",
            "channel": 132,
            "channel_width": 40
        }
    ]
}

it's better than:

{
    "type": "DeviceConfiguration",
    "radios": [
        {
            "name": "radio0",
            "phy": "phy0",
            "protocol": "802.11n",
            "channel": 140,
            "channel_width": 20,
            "country": "EN"
        },
        {
            "name": "radio1",
            "phy": "phy1",
            "protocol": "802.11n",
            "channel": 132,
            "channel_width": 40,
            "country": "EN"
        }
    ]
}

Because the latter repeats the "country" option for each radio.

PS: this is somewhat similar to #41, in which an interface related setting is included in the "general" section because it affects several parts of the configuration and not a specific one.

@nemesifier nemesifier added this to the Draft 0 milestone Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant