Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor script to separate out starting and updating zwift #96

Closed
hobeone opened this issue Apr 24, 2024 · 3 comments
Closed

Refactor script to separate out starting and updating zwift #96

hobeone opened this issue Apr 24, 2024 · 3 comments
Assignees

Comments

@hobeone
Copy link
Contributor

hobeone commented Apr 24, 2024

As described in pull request #94 it would be good to split out the code that starts Zwift vs the code that updates it. Filling a bug to understand the background and requirements.

@netbrain what did you want to get out of this refactor?

@netbrain
Copy link
Owner

The entrypoint script has two responsibilities today.

  1. Update game files, which it does on the first run, or when update argument is present.
  2. Start Zwift.

Would be good to split this into a update.sh and a start.sh. this would further modularize this solution and make it possible for reuse in other use cases.

@hobeone
Copy link
Contributor Author

hobeone commented Apr 25, 2024

Working through this now.

Is there a reason that the script exits after installing? I would expect it to install Zwift if it isn't already there and then start it.

@netbrain
Copy link
Owner

It's probably due to how the github actions are set up and how we build the zwift container (which you know contains all game files)

So first we run the "empty zwift image" which runs with the update flag and simply downloads the latest zwift files. Then we commit's that container instance to a new image i.e zwift:latest and zwift:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants