Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update not working anymore in GH actions #106

Closed
netbrain opened this issue May 5, 2024 · 9 comments
Closed

Update not working anymore in GH actions #106

netbrain opened this issue May 5, 2024 · 9 comments

Comments

@netbrain
Copy link
Owner

netbrain commented May 5, 2024

Think it's due to update flag not being forwarded to

gosu user:user /bin/setup_and_run_zwift

@hobeone ☝️

@hobeone
Copy link
Contributor

hobeone commented May 5, 2024

See #107

@netbrain
Copy link
Owner Author

netbrain commented May 5, 2024

Still something wrong with the gh action. Not sure why it's failing. But I'll look into out when I got the time

@hobeone
Copy link
Contributor

hobeone commented May 6, 2024

Can you run gh actions locally to test them out? I can try to debug as well if so.

@netbrain
Copy link
Owner Author

netbrain commented May 6, 2024

https://github.com/nektos/act

but it's probably easier to try to run the container as it's run with the github action.
https://github.com/netbrain/zwift/blob/master/.github/workflows/zwift_updater.yaml

@netbrain
Copy link
Owner Author

netbrain commented May 6, 2024

But actually, now that im looking it seems that its caused by the script files you updated has not been update in the container. ( https://github.com/netbrain/zwift/blob/master/.github/workflows/zwift_push.yaml )

This yaml is supposed to update the existing container image with latest script files like the entrypoint.sh and stuff. Actually made a note of this in #99.

So we should really fix #99 which in turn would have fixed this issue aswell after your change in #107

@netbrain
Copy link
Owner Author

netbrain commented May 6, 2024

Though it doesn't look like it fixed the update routine 😮‍💨

https://github.com/netbrain/zwift/actions/runs/8968054365/job/24626741254#step:5:182


'[' '' = update ']'

Seems like the update flag still isn't being forwarded, and that it just simply runs zwift instead of updating.

Ill try to build from scratch in order to exclude any errors in the zwift_push gh action. and then see if it works from next version bump

@sHedC
Copy link
Collaborator

sHedC commented May 7, 2024

Looking into this too as podman is broke so trying to merge better for both docker and podman.

@sHedC
Copy link
Collaborator

sHedC commented May 7, 2024

I have done a partial update to here https://github.com/sHedC/zwift but having some issues with persistance and permissions in Podman, working on it.

@netbrain
Copy link
Owner Author

It's probably working now, closing for now and re-opening if it fails on next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants