Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with the @nestjs/fastify-adaptor #250

Open
Jefftopia opened this issue May 14, 2020 · 4 comments
Open

Add compatibility with the @nestjs/fastify-adaptor #250

Jefftopia opened this issue May 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@Jefftopia
Copy link

Jefftopia commented May 14, 2020

I'm submitting a...


[ ] Regression 
[ X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

I am not sure if this is a bug, or a feature request.

Current behavior

  1. git clone https://github.com/TrilonIO/nestjs-azure-functions - the azure func demo app.
  2. npm install --save @nestjs/platform-fastify
  3. npm install the rest.
  4. Swap the default express adaptor with the fastify one.
  5. Make sure you have Azure's func cli installed, then npm run build && func host start.
  6. Open a valid endpoint. In this case, the url logged when func host start has completed and the server is running.

Expected behavior

Fastify should have the same 200 success response as Express adaptor.

Minimal reproduction of the problem with instructions

See instructions above.

What is the motivation / use case for changing the behavior?

I'd like to use Fastify with Azure functions as it's lighter weight and faster.

Environment

MacOS Catalina
NodeJS: 12.16.3

NestJS common, core: 7.0.8
NestJS platform-fastify 7.0.11
@nestjs/azure-func-http: 0.5.0
@azure/functions: 1.0.3

Others:
npm
VSCode
zsh

@kamilmysliwiec kamilmysliwiec changed the title Not compatible with @nestjs/fastify-adaptor Add compatibility with the @nestjs/fastify-adaptor May 23, 2020
@kamilmysliwiec kamilmysliwiec added the enhancement New feature or request label May 23, 2020
@Jefiozie
Copy link
Contributor

Hi @kamilmysliwiec is this something that we should add to this package? If so I think I will have some time to implement it.

Let me know what you think and if I need to know about some specific stuff around fastify

@kamilmysliwiec
Copy link
Member

@Jefiozie course! If you have some spare time, that would be awesome :)

@niklas-wortmann
Copy link

Hi everybody, is there any news about this? Could make use of this in one of my projects.
Btw. you guys are doing an awesome job!

@tastafur
Copy link

still not working, it would be cool if we could make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants