Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Javascript to Typescript #236

Open
Keimeno opened this issue Jul 22, 2020 · 12 comments
Open

Move from Javascript to Typescript #236

Keimeno opened this issue Jul 22, 2020 · 12 comments

Comments

@Keimeno
Copy link
Contributor

Keimeno commented Jul 22, 2020

Request

Since most of nestdotlands code is written in javascript, I think it would be a great idea to convert the project from javascript to typescript.

@zorbyte zorbyte changed the title feat: move from javascript to typescript Move from Javascript to Typescript Jul 22, 2020
@littledivy
Copy link
Member

@Keimeno We are only not-typescript in the website, I think it will be great to migrate, but it should not be a priority. cc @MartonDev

@t8
Copy link
Member

t8 commented Jul 23, 2020

This has certainly been a topic of conversation. I think we're shooting for a TS rewrite in MVP 3. 👍

@martonlederer
Copy link
Member

Good idea. I want to do this to with @t8 personally

@zorbyte
Copy link
Contributor

zorbyte commented Jul 23, 2020

I would love to contribute to this project as well. Personally, I think we should do this in MVP 3.

@martonlederer
Copy link
Member

In my opinion, Vue doesn't really fit with typescript. If we really want to use it, we should migrate to react or svelte

@Keimeno
Copy link
Contributor Author

Keimeno commented Jul 23, 2020

Thats not the case with Vue 2.6. Typescript is perfectly integrated. The only annoying part is, that .vue files need to be declared, and you loose the autocompletion of props. Also a complete rewrite wouldn't make sense. Especially migrating from vue to react.

@littledivy
Copy link
Member

littledivy commented Jul 23, 2020

A complete rewrite would not only allow us to integrate Typescript , Vuex and Yolk more easily but also fix the current issues! I'd love to contribute in this part.

@HermitSun
Copy link
Contributor

HermitSun commented Aug 2, 2020

Or we can wait for the coming Vue 3, it is now in rc5😊. And I'd like to contribute to it.

@martonlederer
Copy link
Member

Yeah we should wait until Vue 3. We'd love your contribution.

@t8
Copy link
Member

t8 commented Aug 2, 2020

@HermitSun feel free to email me your discord username, and I'll send you an invite to our internal chat! It may be easier to coordinate from there.

My email: tate@arceum.co

@Keimeno
Copy link
Contributor Author

Keimeno commented Aug 2, 2020

Maybe we should even build the project with nuxt then. One of the best things about npmjs.com is, that all packages are indexed by google.

@t8
Copy link
Member

t8 commented Aug 2, 2020

@Keimeno good point. We actually have some new developments regarding that 😄

CC @maximousblk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants