Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor, badge rendering with README file #132

Open
fakoua opened this issue Jun 25, 2020 · 8 comments
Open

Minor, badge rendering with README file #132

fakoua opened this issue Jun 25, 2020 · 8 comments
Assignees

Comments

@fakoua
Copy link

fakoua commented Jun 25, 2020

The readme file renders the badges in the same line with github, while nest renders the badge in two separate lines, minor but fixing it would be great.
Thanks

@fakoua fakoua added the bug label Jun 25, 2020
@t8
Copy link
Member

t8 commented Jun 25, 2020

@fakoua thanks for letting us know. Could you attach a link and/or a screenshot so we can see what is happening?

@fakoua
Copy link
Author

fakoua commented Jun 25, 2020

@fakoua thanks for letting us know. Could you attach a link and/or a screenshot so we can see what is happening?

For example:

https://github.com/fakoua/deno_gui
and
https://nest.land/package/deno_gui

Please check how the badge are rendered.

Thanks

@t8
Copy link
Member

t8 commented Jun 25, 2020

I see. This is very interesting. If you visit Opine's module page, this does not occur. As a workaround, try formatting your README badges like Craig Morten does here: https://raw.githubusercontent.com/asos-craigmorten/opine/main/README.md

Note: Craig uses HTML elements instead of markdown.

Let me know if this helps fix your problem!

@fakoua
Copy link
Author

fakoua commented Jun 25, 2020

Hi @tbaumer22 ,
It is fine for Opine, but my concern is not a specific package, we need consistency between github and nest.

@t8
Copy link
Member

t8 commented Jun 25, 2020

Yes, you're right. I completely agree. We'll investigate a solution to this problem when we can. Until then, feel free to use Craig Morten's method above!

Thanks again for reporting this.

@maximousblk
Copy link
Member

seems to be a problem with vue-markdown. it adds a <br> tag after each image.

image

@zorbyte zorbyte changed the title [BUG] Minor, badge rendering with README file Minor, badge rendering with README file Jul 14, 2020
@balupton
Copy link

balupton commented Jul 23, 2020

You can use https://github.com/bevry/projectz for maintaining the readme badges via <!-- BADGES --> inside the readme, it uses package.json:badges and other information from inside package.json to populate them.

@t8
Copy link
Member

t8 commented Jul 24, 2020

I'm afraid that our issue here has to do with the way the badges are displayed on the site and not the badge files themselves.

@MartonDev is this something that can be fixed with your experimental vue-markdown in development?

@martonlederer martonlederer linked a pull request Oct 5, 2020 that will close this issue
2 tasks
@martonlederer martonlederer removed a link to a pull request Oct 5, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants