Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang-format does not support JavaScript error #3182

Open
jessica-mitchell opened this issue Apr 16, 2024 · 1 comment · May be fixed by #3203
Open

Clang-format does not support JavaScript error #3182

jessica-mitchell opened this issue Apr 16, 2024 · 1 comment · May be fixed by #3203
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: External bug Not an issue that can be solved here. (May need documentation, though)
Projects
Build system and CI

Comments

@jessica-mitchell
Copy link
Contributor

The pre-commit hook for clang-format errors out when committing javascript files:
configuration file(s) do(es) not support JavaScript
This seems to have been introduced from changing from version 13.0.0 to 17.0.4

The problem can be solved by explicitly adding types_or: [c++, python] to the config file.
Clang then skips the javascript file altogether.
Or we can update the clang version to >= 18.1.0
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) T: External bug Not an issue that can be solved here. (May need documentation, though) labels Apr 16, 2024
@jessica-mitchell jessica-mitchell added this to To do in Build system and CI via automation Apr 16, 2024
@terhorstd
Copy link
Contributor

Discussed in ONDVC on 2024-04-22: We should go for the types_or: [c++, python] solution.

@jessica-mitchell jessica-mitchell linked a pull request May 2, 2024 that will close this issue
Open
@gtrensch gtrensch moved this from To do to In progress in Build system and CI May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: External bug Not an issue that can be solved here. (May need documentation, though)
Projects
Build system and CI
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify model directory documentation UI and related pages jessica-mitchell/nest-simulator
2 participants
@jessica-mitchell @terhorstd