Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use higher mathematical functions available per C++17 #3135

Open
heplesser opened this issue Mar 5, 2024 · 1 comment
Open

Refactor to use higher mathematical functions available per C++17 #3135

heplesser opened this issue Mar 5, 2024 · 1 comment
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation Kernel

Comments

@heplesser
Copy link
Contributor

Per C++17, a large number of higher mathematical functions (are available in C++ via <cmath>)[https://en.cppreference.com/w/cpp/header/cmath]. Values for infininty, not-a-number and similar are also part of the header, actually have been since C++11.

We can therefore

  • remove several work-arounds in numerics.h
  • remove corresponding CMake checks
  • possibly remove some GSL or Boost-dependencies
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) good first issue Good for newcomers labels Mar 5, 2024
@heplesser heplesser added this to To do in Installation via automation Mar 5, 2024
@heplesser heplesser added this to To do (open issues) in Kernel via automation Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation
  
To do
Kernel
  
To do (open issues)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heplesser