Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting nodes with spatial positions fails in corner case #3130

Open
heplesser opened this issue Mar 2, 2024 · 1 comment
Open

Connecting nodes with spatial positions fails in corner case #3130

heplesser opened this issue Mar 2, 2024 · 1 comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects

Comments

@heplesser
Copy link
Contributor

In NEST master (355e52d) Connect() fails in the following situation

l = nest.Create('parrot_neuron', n=20,
                positions=nest.spatial.free(pos=[(j+1, 0) for j in range(20)], edge_wrap=True))
nest.Connect(l, l, {"rule": "pairwise_bernoulli", "p": 1.0, "mask": {"circular": {"radius": 1.2}}})

with

Assertion failed: (( pos - lower_left_ )[ i ] > -std::numeric_limits< double >::epsilon() and ( lower_left_ + extent_ - pos )[ i ] > -std::numeric_limits< double >::epsilon()), function insert, file ntree_impl.h, line 487.

All works fine if edge_wrap=False. This is likely a corner case of rounding coordinates. See also #2466.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 2, 2024
@heplesser heplesser added this to To do (open issues) in Kernel via automation Mar 2, 2024
Copy link

github-actions bot commented May 2, 2024

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
To do (open issues)
Development

No branches or pull requests

1 participant