Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the IntegrationTestRPC::truncate functionality works properly in non-dev mode #4230

Open
eval-exec opened this issue Nov 13, 2023 · 0 comments · May be fixed by #4292
Open

Ensure that the IntegrationTestRPC::truncate functionality works properly in non-dev mode #4230

eval-exec opened this issue Nov 13, 2023 · 0 comments · May be fixed by #4292
Assignees
@zhangsoledad
Labels
p:should-have Priority: important but not necessary for delivery in the current delivery timebox t:enhancement Type: Feature, refactoring.

Comments

@eval-exec
Copy link
Collaborator

eval-exec commented Nov 13, 2023 •
edited

Feature Request

Currently, the IntegrationTestRPC::truncate RPC is disabled in non-dev mode, and it doesn't work well in non-dev mode.

ckb/rpc/src/service_builder.rs

Lines 158 to 163 in 98678a8

// IntegrationTest only on Dummy PoW chain
assert_eq!(
shared.consensus().pow,
Pow::Dummy,
"Only run integration test on Dummy PoW chain"
);

Consider adding the truncate feature as a subcommand in CKB, similar to ckb reset-data. This would be beneficial for non-dev mode usage.
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Nov 13, 2023
@eval-exec eval-exec changed the title Allow IntegrationTestRPC::truncate work in non-dev mode Make sure IntegrationTestRPC::truncate work well in non-dev mode Nov 13, 2023
@eval-exec eval-exec changed the title Make sure IntegrationTestRPC::truncate work well in non-dev mode Ensure that the IntegrationTestRPC::truncate functionality works properly in non-dev mode Nov 13, 2023
@chenyukang chenyukang self-assigned this Nov 15, 2023
@eval-exec eval-exec assigned eval-exec and unassigned chenyukang Nov 21, 2023
@eval-exec eval-exec added the p:should-have Priority: important but not necessary for delivery in the current delivery timebox label Nov 21, 2023
@eval-exec eval-exec assigned zhangsoledad and unassigned eval-exec Nov 30, 2023
@eval-exec eval-exec linked a pull request Jan 4, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangsoledad zhangsoledad

Labels
p:should-have Priority: important but not necessary for delivery in the current delivery timebox t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add truncate-block subcommand eval-exec/ckb
3 participants
@chenyukang @zhangsoledad @eval-exec