Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if image names and --private don't cause validation errors #402

Open
advanderveer opened this issue Apr 13, 2018 · 1 comment
Open

Check if image names and --private don't cause validation errors #402

advanderveer opened this issue Apr 13, 2018 · 1 comment
Assignees
@LilliJane
Labels
P0

Comments

@advanderveer
Copy link
Contributor

Expected Behavior

We've seen in #397 that some images cause the label validation of secrets to error. We need to make sure this doesn't happen with any other characters.
@LilliJane
Copy link
Contributor

LilliJane commented Apr 13, 2018 •
edited

If someone uses a private registry and precises a port e.g myregistryhost:5000/fedora/httpd:version1.0, our current setup could fail

@LilliJane LilliJane added the P0 label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilliJane LilliJane

Labels
P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@advanderveer @LilliJane