Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more syntax features: keycodes, special, parameters #1

Open
4 of 5 tasks
clason opened this issue Mar 26, 2022 · 1 comment · May be fixed by #109
Open
4 of 5 tasks

more syntax features: keycodes, special, parameters #1

clason opened this issue Mar 26, 2022 · 1 comment · May be fixed by #109
Labels
enhancement New feature or request

Comments

@clason
Copy link
Member

clason commented Mar 26, 2022

In testing this parser for nvim-treesitter (nvim-treesitter/nvim-treesitter#2679), I noticed that some features are not yet supported, especially

(See https://github.com/nanotee/vimdoc-notes for the most comprehensive specification of vimdoc I've seen so far.)

@vigoux
Copy link
Member

vigoux commented Apr 1, 2022

I will use this issue as tracking for missing features in the language if that's okay for you, feel free to add stuff to the original comment.

@justinmk justinmk reopened this Sep 28, 2022
justinmk added a commit to justinmk/tree-sitter-vimdoc that referenced this issue Oct 5, 2022
@justinmk justinmk reopened this Oct 5, 2022
@justinmk justinmk changed the title Support additional syntax features more syntax features: keycodes, special, parameters Oct 14, 2022
@justinmk justinmk added the enhancement New feature or request label Jun 25, 2023
justinmk added a commit that referenced this issue Jun 25, 2023
@justinmk justinmk linked a pull request Jun 25, 2023 that will close this issue
justinmk added a commit that referenced this issue Jun 25, 2023
justinmk added a commit that referenced this issue Jun 25, 2023
justinmk added a commit that referenced this issue Jun 25, 2023
justinmk added a commit that referenced this issue Jun 25, 2023
justinmk added a commit that referenced this issue Jun 26, 2023
justinmk added a commit that referenced this issue Jun 26, 2023
Problem:
Using _word() to define an optional arg leads to a lot of syntax errors in
real-world :help files because [brackets] are commonly used for non-args.

Solution:
Define (optional) with a regex, like (keycode) instead of using the more
"formal" mechanism. Regex has "best-effort" behavior, while seq() behaves more
strictly.

Don't treat `[{arg}]` as (optional), else it clobbers the nested `{arg}`.

fix #1
justinmk added a commit that referenced this issue Jun 26, 2023
justinmk added a commit that referenced this issue Jun 26, 2023
Problem:
Using _word() to define an optional arg leads to a lot of syntax errors in
real-world :help files because [brackets] are commonly used for non-args.

Solution:
Define (optional) with a regex, like (keycode) instead of using the more
"formal" mechanism. Regex has "best-effort" behavior, while seq() behaves more
strictly.

Don't treat `[{arg}]` as (optional), else it clobbers the nested `{arg}`.

fix #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants