Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovide will crash when launching with "-- -h" or "-- -v" #2446

Open
sleeptightAnsiC opened this issue Mar 26, 2024 · 0 comments
Open

Neovide will crash when launching with "-- -h" or "-- -v" #2446

sleeptightAnsiC opened this issue Mar 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sleeptightAnsiC
Copy link

sleeptightAnsiC commented Mar 26, 2024

Hi,

If you try to launch neovide with arguments that force nvim to print something to stdout and close (like version or help), then the neovide will not print those information but instead it will crash.

Steps To Reproduce

  1. Run following from the terminal: neovide -- -h or neovide -- -v
  2. Notice a message about crash

Expected behavior
Neovide should launch nvim with -h or -v argument, grab nvim's stdout, print it to terminal and close. The behavior should be the same as if user was launching nvim -h or nvim -v

Desktop:

  • OS - Arch Linux x86_64 (6.8.1-arch1-1)
  • Neovide Version - Tested on 0.12.2-1 (installed via pacman) and on latest a11c8e3 (0.12.2) built from source
  • Neovim Version - v0.9.5 Release (installed via pacman)

Log:

TRACE [neovide] Neovide version: 0.12.2
DEBUG [neovide::settings::window_size] Loaded window settings: Maximized
DEBUG [neovide::bridge::command] Starting neovim with: Command { std: "/usr/bin/nvim" "--embed" "-p" "-h", kill_on_drop: false }
ERROR [neovide::error_handling] Neovide just crashed :(
This is the error that caused the crash. In case you don't know what to do with this, please feel free to report this on https://github.com/neovide/neovide/issues!

Neovide requires nvim version 0.9.2 or higher. Download the latest version here https://github.com/neovim/neovim/wiki/Installing-Neovim

Notes:

  • Perhaps, there are more arguments causing the crash. I haven't tested all of them
  • Crash message mentions downloading higher version of nvim, 0.9.2 or higher, but I clearly have a higher version.
  • I tried to grab callstack via LLDB/codelldb, but I'm unfamiliar with Rust and failed to do so. I can provide one with a little bit of help. I was able to step into the code, and it was failing somewhere there:
 neovide::bridge::launch::{{closure}} mod.rs:89
 tokio::runtime::park::CachedParkThread::block_on::{{closure}} park.rs:281
 tokio::runtime::coop::with_budget coop.rs:107
 tokio::runtime::coop::budget coop.rs:73
 tokio::runtime::park::CachedParkThread::block_on park.rs:281
 tokio::runtime::context::blocking::BlockingRegionGuard::block_on blocking.rs:66
 tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}} mod.rs:87
 tokio::runtime::context::runtime::enter_runtime runtime.rs:65
 tokio::runtime::scheduler::multi_thread::MultiThread::block_on mod.rs:86
 tokio::runtime::runtime::Runtime::block_on runtime.rs:350
 neovide::bridge::NeovimRuntime::launch mod.rs:163
 neovide::setup main.rs:204
 neovide::main main.rs:93

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant