Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiered compaction: refactor and re-enable iterator based k-merge #7703

Open
Tracked by #7554
arpad-m opened this issue May 10, 2024 · 1 comment
Open
Tracked by #7554

tiered compaction: refactor and re-enable iterator based k-merge #7703

arpad-m opened this issue May 10, 2024 · 1 comment
Assignees
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@arpad-m
Copy link
Member

arpad-m commented May 10, 2024

PR #7661 has switched to a completely in-memory based k-merge due to assertion errors in the iterator based k-merge. This has a non-zero memory impact bounded on the number of delta layers considered at a time multiplied by the maximum layer size. Ideally, we'd find and fix the bugs in the k-merge implementation.

Also, tests for the k-merge would be very helpful.

@skyzh has expressed interest in this, or at least in refactoring the k-merge.

@problame
Copy link
Contributor

problame commented May 15, 2024

Meeting notes: Chi authored #7760 which fixes this. Still missing test case.
Should be able to use the test that failed before we switched to buffered kmerge.

Time budget to understand with what was wrong with the prior kmerge: 1/2 day.
(NB the failure might now have been due to a bug in the prior kmerge impl, but the load/unload functionality)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

No branches or pull requests

3 participants