Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default options to promote secure connections #13

Open
neocotic opened this issue Mar 24, 2017 · 1 comment
Open

Change default options to promote secure connections #13

neocotic opened this issue Mar 24, 2017 · 1 comment

Comments

@neocotic
Copy link
Owner

neocotic commented Mar 24, 2017

When support for JSON requests was added in 2.1.0, JSONP was kept as the default format to avoid it being a breaking change.

However, since this means that credentials are sent in the clear (by design, for JSONP), we should promote secure connections by changing the default options to the following:

{
  format: 'json',
  method: 'POST'
}
@neocotic neocotic added this to the 3.0.0 milestone Mar 24, 2017
@neocotic neocotic mentioned this issue Mar 24, 2017
4 tasks
@neocotic neocotic changed the title Change default for "format" option to "json" Change default options to promote secure connections Mar 24, 2017
@neocotic
Copy link
Owner Author

I believe that the default value for the method option should be based on the value resolved for the format option:

format Default for method
json POST
jsonp GET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant