Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Tim Pope's vim endwise #297

Closed
npearson72 opened this issue Dec 26, 2018 · 3 comments
Closed

Conflict with Tim Pope's vim endwise #297

npearson72 opened this issue Dec 26, 2018 · 3 comments

Comments

@npearson72
Copy link

Result from CocInfo

## versions

vim version: NVIM v0.3.1
node version: v11.5.0
coc.nvim version: 0.0.41
term: iTerm.app
platform: darwin

## Error messages

## Output channel: tsserver
[Info  - 2:44:23 AM] Forking TSServer
PATH: /Users/nathan/.yarn/bin:/Users/nathan/.config/yarn/global/node_modules/.bin:/Users/nathan/.rbenv/shims:/Users/nathan/bin:/Users/nathan/rbenv/bin:/usr/local/opt/coreutils/libexec/gnubin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/opt/fzf/bin 
[Info  - 2:44:23 AM] Started TSServer
{
  "path": "/Users/nathan/.config/coc/extensions/node_modules/typescript/lib",
  "_pathLabel": "",
  "_api": {
    "versionString": "3.2.2",
    "version": "3.2.2"
  }
}

## Output channel: eslint
[Info  - 2:44:23 AM] ESLint server running in node v11.5.0
[Info  - 2:44:24 AM] ESLint library loaded from: /Users/nathan/Dev/learning/js/udemy/react-16-6-the-complete-guide--maximilian-schwarzmuller/react-complete-guide/node_modules/eslint/lib/api.js

Describe the bug
Using the following remapping breaks the completion:

inoremap <expr><cr> pumvisible() ? "\<c-y>" : "\<cr>"

It appears this issue only happens due to a conflict with https://github.com/tpope/vim-endwise

I'm hoping you might advise on how I can resolving the mapping.

To Reproduce
Steps to reproduce the behavior:

See screenshots below...

Screenshots

Menu appears and selection is made:
screen shot 2018-12-26 at 2 46 44 am

Hitting the Enter key:
screen shot 2018-12-26 at 2 46 52 am

@oblitum
Copy link
Member

oblitum commented Dec 26, 2018

That mapping is just a suggestion, you may not use it and simply rely on Vim's built in confirmation key, <c-y>.

related: #262 (comment)

@chemzqm
Copy link
Member

chemzqm commented Dec 26, 2018

Your mapping is not taking effect. Checkout verbose imap <CR>.
Use let g:endwise_no_mappings=1 or use other key for confirm completion.

@chemzqm chemzqm closed this as completed Dec 26, 2018
@npearson72
Copy link
Author

BTW... I also wanted to just say thank you for the great plugin! Not only is it feature rich and modular, but it's the only one that I have tried with a language client that works properly for ruby (i.e. solagraph).

Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants