Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Add linkedEditing LSP feature #423

Closed
qiqiboy opened this issue Apr 10, 2023 · 5 comments · Fixed by #427
Closed

[feature request]Add linkedEditing LSP feature #423

qiqiboy opened this issue Apr 10, 2023 · 5 comments · Fixed by #427

Comments

@qiqiboy
Copy link

qiqiboy commented Apr 10, 2023

Typescript already supports linkedEditing(not yet released, but available in v5.1.0-dev.20230409).

@fannheyward
Copy link
Member

This is the server side support, right? coc.nvim already has linkedEditing support, you can enable it by setting coc.preferences.enableLinkedEditing to true.

@qiqiboy
Copy link
Author

qiqiboy commented Apr 10, 2023

I tried it, but didn't work. The coc-html works fine. I searched 'linkedediting' in coc-html, and found some relevant codes. So I think there should be some adaptation work to be done.

@fannheyward
Copy link
Member

fannheyward commented Apr 10, 2023

Got your point, but that PR is for TypeScript, coc-tsserver is something like https://github.com/microsoft/vscode/tree/main/extensions/typescript-language-features and , let's see how VSCode handle this in typescript-language-features.

https://github.com/search?q=repo%3Amicrosoft%2Fvscode+linkedediting&type=code&p=1

Only html-language-features supports linkedEditing in VSCode for now, same as coc-html.

@qiqiboy
Copy link
Author

qiqiboy commented Apr 10, 2023

From vscode's April iteration plan, this feature will be released in early May. The maintainers of vscode are already working on it: mjbvz/vscode@2d63e7c.

@fannheyward
Copy link
Member

microsoft/vscode#176279

fannheyward added a commit to fannheyward/coc-tsserver that referenced this issue May 9, 2023
fannheyward added a commit to fannheyward/coc-tsserver that referenced this issue Jun 2, 2023
chemzqm pushed a commit that referenced this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants