Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero length path eagerload #1667

Closed
wants to merge 6 commits into from
Closed

Conversation

amitsuryavanshi
Copy link
Member

Fixes #1666

This pull introduces/changes:

  • Allows zero length in eager load.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1667 (1a77b92) into master (84f6193) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   93.73%   93.76%   +0.02%     
==========================================
  Files         126      127       +1     
  Lines        5684     5707      +23     
==========================================
+ Hits         5328     5351      +23     
  Misses        356      356              
Impacted Files Coverage Δ
lib/active_graph.rb 98.18% <100.00%> (+0.03%) ⬆️
...tive_graph/node/query/query_proxy_eager_loading.rb 100.00% <100.00%> (ø)
...uery/query_proxy_eager_loading/association_tree.rb 100.00% <100.00%> (ø)
lib/active_graph/string_parsers/relation_parser.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f6193...1a77b92. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2022

Code Climate has analyzed commit 1a77b92 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@amitsuryavanshi
Copy link
Member Author

Closing in favour of activegraph-edge gem. This will moved to activegraph-edge gem

@amitsuryavanshi amitsuryavanshi deleted the zero_length_path_eagerload branch January 5, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow zero length paths in eagerload
2 participants