Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit code for arguments that should be keyword-only #1616

Open
tbekolay opened this issue May 17, 2020 · 0 comments
Open

Audit code for arguments that should be keyword-only #1616

tbekolay opened this issue May 17, 2020 · 0 comments

Comments

@tbekolay
Copy link
Member

Is your feature request related to a problem? Please describe.

There are several objects that I've only every seen called with keyword arguments, and without them they're very hard to parse. I'd be willing to be bet that no one reading this will know what these do without looking them up.

nengo.Ensemble(10, 1, 2)
nengo.Connection(pre, post, 0.1, solver=LstsqL2(True, 0.2))

Describe the solution you'd like

Since we dropped Python 2.7 support, we can now use keyword-only arguments, which would make the above raise a TypeError.

We should go through the things listed in the frontend API and make arguments keyword-only where appropriate.

Additional context

This will be a breaking change, so this might be a good thing to do for Nengo 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant