Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more tests #1

Open
3 of 5 tasks
nelsonxb opened this issue Jan 28, 2020 · 5 comments
Open
3 of 5 tasks

Need more tests #1

nelsonxb opened this issue Jan 28, 2020 · 5 comments
Labels
category:bug Something isn't working, or is insufficient priority:critical Everything is wrong and this needs addressing NOW

Comments

@nelsonxb
Copy link
Owner

nelsonxb commented Jan 28, 2020

The current tests are kinda useful for running a debugger on, but we need a lot more.

  • Tests with threads resuming other threads;
  • Tests for detecting corruption (how?);
  • Tests verifying that error conditions have the correct return values;
  • Test that C++ exceptions still work (with complex switching);
  • Test thread safety (how?);
@nelsonxb
Copy link
Owner Author

nelsonxb commented Jan 29, 2020

Hmm... I reckon cc31512 deals with the second item.

@nelsonxb nelsonxb added category:bug Something isn't working, or is insufficient priority:critical Everything is wrong and this needs addressing NOW labels Jan 29, 2020
@nelsonxb
Copy link
Owner Author

So... until now I've actually just been kind of assuming that green's current strategy will play nice with C++ exceptions? Guess that should probably also get tests.

@nelsonxb
Copy link
Owner Author

The second item should be properly addressed as of 17f90c5.

@nelsonxb nelsonxb pinned this issue Jan 30, 2020
@nelsonxb nelsonxb unpinned this issue Jan 30, 2020
@nelsonxb
Copy link
Owner Author

First point should be OK as of b3fcacc.

@nelsonxb nelsonxb pinned this issue Jan 31, 2020
@nelsonxb
Copy link
Owner Author

Third point done with fdec8e7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Something isn't working, or is insufficient priority:critical Everything is wrong and this needs addressing NOW
Projects
None yet
Development

No branches or pull requests

1 participant