Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default hashing algorithm used in signed cookies #324

Open
javiereguiluz opened this issue Apr 27, 2023 · 0 comments
Open

Update the default hashing algorithm used in signed cookies #324

javiereguiluz opened this issue Apr 27, 2023 · 0 comments

Comments

@javiereguiluz
Copy link
Contributor

This bundle uses sha256 as the default hashing algorithm for signed cookies:

NelmioSecurityBundle/src/DependencyInjection/Configuration.php

Line 255 in 93f8009

->scalarNode('hash_algo')->defaultValue('sha256')->end()

This might be no longer safe enough: https://en.wikipedia.org/wiki/SHA-2#Comparison_of_SHA_functions

Maybe we can move to sha3-256 or higher, which is also supported by PHP? https://www.php.net/manual/en/function.hash-algos.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javiereguiluz