Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Contribution] Extending CSP to include Trusted-Types headers #233

Open
henrym2 opened this issue Aug 11, 2020 · 3 comments
Open

Comments

@henrym2
Copy link

henrym2 commented Aug 11, 2020

Hi Nelmio Team,

I wanted to open a discussion with respect to extending the current CSP module to include support for trusted-types and require-trusted-types-for headers. Although both Symfony and the NelmioSecurityBundle have little to no control over the JavaScript embedded on the sites that use them, extending the configuration for CSP to include these new directives will hopefully empower developers to make use of the new features provided by them.

Trusted Types hopes to limit the number of potential DOM XSS sinks in an application by instead replacing them with Trusted HTML types. Some documentation on the extent of the trusted Types feature can be found here and an article detailing the benifits and reductions to DOM based XSS provider can be found here.

I've made a rough implementation of this on a fork of the bundle and would like to know if you would be receptive to me opening a PR referencing it.

Thanks!

@henrym2 henrym2 changed the title Extending CSP to include Trusted-Types headers [Feature Contribution] Extending CSP to include Trusted-Types headers Aug 11, 2020
@thedustin
Copy link

Stumbled upon this, while moving our CSP configuration to Symfony, to have more control over it.
Are there any plans to discuss this or even to merge this pull request? 👀

@henrym2
Copy link
Author

henrym2 commented Jun 14, 2023

I'd be happy to bring it up to date if I could get a review of it 😅 - But it has been about two years since it was opened and so far the Nelmio bundle team hasn't interacted with the inclusion
https://github.com/nelmio/NelmioSecurityBundle/pull/235/files

@Seldaek
Copy link
Member

Seldaek commented Jun 14, 2023

Yeah sorry there's hardly anyone here with bandwidth to maintain the bundle.. The PR looks fine to me at first glance but I'm kinda worried of just merging random stuff without fully understanding them given the security aspects of this bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants