Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thirdparty #32

Open
zellx3 opened this issue Jan 22, 2021 · 7 comments
Open

Thirdparty #32

zellx3 opened this issue Jan 22, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@zellx3
Copy link

zellx3 commented Jan 22, 2021

Hello.

I decided to use cupoch in our project, since we needed to couple it with vcpkg. First idea was just to compile it seperatly.
But since cupoch have it's own dependencies it's conflicted with same dependecies in the vcpkg also in some cases like flann cupoch use minimal edited version.

So we decieded to start to change the build system of cupoch and make it possible to integrate it in the vcpkg.
I will be happy to share it here and improve it, currently it's not perfectly implemented but it's work for us.

@neka-nat neka-nat added the enhancement New feature or request label Jan 22, 2021
@neka-nat
Copy link
Owner

Hi,
Thanks for the great suggestion!
I agree that we should be able to use vcpkg.

In my opinion, I would like to modify the build system by making as many small changes as possible.
Is it possible to partially use vcpkg while keeping some of the original thirdparty?
Is it difficult to coexist with both?

@zellx3
Copy link
Author

zellx3 commented Jan 22, 2021

Actually, we can port the 3rdparties one by one. There will be no problem.

In normal cases, if you use cupoch in a small project there will be no problem. but linking it with project with having another version of those 3rdparties will cause linking problems.

But to start porting it we can do it one by one.

Also, I should mention that the flann that exists in the 3rdparty folder is not the official Flann. That needs to be fixed especially.

@zellx3
Copy link
Author

zellx3 commented Jan 22, 2021

Also, I should mention some of the 3rdparties are not available in vcpkg. we can start with the ones that is available.

@neka-nat
Copy link
Owner

neka-nat commented Jan 25, 2021

I agree to start porting third parties one by one!
If you submit pull requests, I will respond accordingly.
As for flann, it has some bug fixes in it, so it cannot replace the original one.

@zellx3
Copy link
Author

zellx3 commented Jan 25, 2021

Regarding Flann, Yes I saw your changes, I solved it by subclassing Flann (I can't remember the correct class name) in cupoch and integrate the changes in the subclass instead of changing Flann.

@zellx3
Copy link
Author

zellx3 commented Jan 25, 2021

Then I will close this pull request and start to port the 3rdparties one by one.

@neka-nat
Copy link
Owner

I have not yet figured out what we should do about handling flann.
I also need to understand vcpkg better.
I don't foresee any problems with migrating common libraries such as glew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants