Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment inserted without the leading /**. #240

Open
nu111 opened this issue Oct 12, 2023 · 7 comments
Open

Comment inserted without the leading /**. #240

nu111 opened this issue Oct 12, 2023 · 7 comments

Comments

@nu111
Copy link

nu111 commented Oct 12, 2023

When generating the DocBlock comment, the comment it's inserted without the leading /**.
It used to work fine a couple of weeks ago.

Here a video of the issue:
https://drive.google.com/file/d/1i6paU614UJD5Xs6Xi9VIRnraPRNDXzXc/view?usp=drive_link

VS Code version: 1.83.1
OS: Kubuntu 22.04
PHP DocBlocker verison: 2.7.0

@Korkman
Copy link

Korkman commented Oct 22, 2023

Confirming this is an issue in current releases

VS Code: 1.83.1
OS: Windows 11
PHP DocBlocker: 2.7.0

@Korkman
Copy link

Korkman commented Oct 22, 2023

It seems to conflict with the setting "Editor: Auto Closing Comments"

Workaround: set it to "never" and PHP DocBlocker works again.

"editor.autoClosingComments": "never"

@neild3r
Copy link
Owner

neild3r commented Oct 22, 2023

Thanks for working out the root cause @Korkman we may be able to detect the setting and adjust appropriately I'll see if I can replicate it myself

@neild3r
Copy link
Owner

neild3r commented Oct 22, 2023

Hmm, just tried on 1.83.1 changing that option to always instead of what I have it as which is the default languageDefined and it doesn't do it

@neild3r
Copy link
Owner

neild3r commented Oct 22, 2023

Are there any other settings you have which may be relevant to replicate the issue?

@nu111
Copy link
Author

nu111 commented Oct 23, 2023

It seems to conflict with the setting "Editor: Auto Closing Comments"

Workaround: set it to "never" and PHP DocBlocker works again.

"editor.autoClosingComments": "never"

My setting was "editor.autoClosingComments": "languageDefined", after changing to never as suggested by @Korkman the problem seems solved.

@neild3r
Copy link
Owner

neild3r commented Oct 31, 2023

In isolation that setting doesn't cause a problem something else must be causing this, perhaps another plugin or something otherwise it would be broken for everybody which doesn't seem to be the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants