Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we combine the two datasets? #20

Open
Redsandro opened this issue Mar 20, 2017 · 1 comment
Open

Can we combine the two datasets? #20

Redsandro opened this issue Mar 20, 2017 · 1 comment

Comments

@Redsandro
Copy link
Contributor

Redsandro commented Mar 20, 2017

We have a long string of emoji data in emoji.min.js and again but different in defaults.emojiData. Can we have just one? Where does the latter come from? Did you create the latter one yourself, or could it be a dependency?


I think you could deprecate the dependency on js-emoji and use emojiData to define images in the layout.

E.g. in stead of

self.emoji.replace_colons(':smile:');

use separate function for something like

(self.emojiData.filter(function(el){el.short_name == 'smile'})[0] || {}).image;

it returns the image (or undefined)

@needim
Copy link
Owner

needim commented Mar 25, 2017

Yep, you are right. I created a new object because I wanted performance gain for the loops. (mainly for this function: wdtEmojiBundle.fillPickerPopup())

It would be nice to have just one object, maybe we can find a better way. And this bundle uses sheets instead of single images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants