Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image scraping to the backend for self-hosters #42

Open
1 task done
ndom91 opened this issue Feb 28, 2023 · 0 comments
Open
1 task done

Add image scraping to the backend for self-hosters #42

ndom91 opened this issue Feb 28, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ndom91
Copy link
Owner

ndom91 commented Feb 28, 2023

Clear and concise description of the problem

Currently the hosted instance of Briefkasten (https://briefkastenhq.com), runs on Vercel which has a 10s limit on its API routes. Meaning, for the API endpoint which saves new bookmarks, it was not possible to also take the screenshot there and keep it consistently under 10s.

So for the hosted instance, I put the screenshot taking into a decoupled message queue that would be worked through by some serverless function workers.

This seems like way too much work for a self-hosted instance, hwoever, plus the self-hosters do not have that arbitrary 10s limit.

Suggested solution

Vercel adds an environment variable VERCEL which is 1 when an application is running on their platform. Therefore, we can easily tell whether we need to run the screenshotting process through the queue, or have the resources to just fire up playwright / puppeteer right in the backend process and take the screenshot immediately upon adding the bookmark.

This is a feature request from myself, just adding this issue to keep track, inform the community, and potentially gather any additional feedback yall may have 🙏

I do not have an ETA on this, but plan to add it soon ™️

Alternative

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@ndom91 ndom91 added the enhancement New feature or request label Feb 28, 2023
@ndom91 ndom91 self-assigned this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant