Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to build C++ interface libraries with NCO-5.0.1 #246

Open
maxim-masterov opened this issue Aug 26, 2021 · 1 comment
Open

Fail to build C++ interface libraries with NCO-5.0.1 #246

maxim-masterov opened this issue Aug 26, 2021 · 1 comment

Comments

@maxim-masterov
Copy link

The --enable-nco_cplusplus option does not affect the configure script. The problem is in the if-statement that determines if the NCO_CXX variable should be set:

nco/configure

Lines 21534 to 21540 in 7d9a7d8

if test "${ac_cv_cxx_have_valarray}" = 'yes' && test "${enable_nco_cxx}" = 'yes' ; then
ac_config_files="$ac_config_files src/nco_c++/Makefile"
NCO_CXX="nco_c++"
else
NCO_CXX=
fi

The ac_cv_cxx_have_valarray variable is not defined in the configure script since v4.9.9. Shouldn't it be removed completely?

@czender
Copy link
Member

czender commented Aug 26, 2021

Thank you for pointing this out. I'd rather repair the option to build libnco_c++, though default that to turn-off, and remove the check on the undefined variable you point out. Testing now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants