Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up namespace pollution from new regridder routines #126

Open
czender opened this issue Apr 19, 2019 · 0 comments
Open

Clean-up namespace pollution from new regridder routines #126

czender opened this issue Apr 19, 2019 · 0 comments
Assignees
@hmb1

Comments

@czender
Copy link
Member

czender commented Apr 19, 2019

Henry,
Recent compiling issues on Windows with nco_crt.c and kd.h demonstrate this issue. We cannot introduce new global tokens with generic names like Unknown. Other packages in the environment that do not follow best practices will clash with such generic names. NCO does not wish to contribute to this pollution. Please rename tokens, functions, and typedefs with an NCO_ or nco_ prefix, respectively. Please rename files kd.* as nco_kd.*. Follow NCO naming conventions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmb1 hmb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@czender @hmb1