Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I wrote a plugin for use with logger++, some unintended errors occurred. #190

Open
17307 opened this issue Aug 8, 2023 · 2 comments
Assignees
Labels

Comments

@17307
Copy link

17307 commented Aug 8, 2023

Description:

When I wrote a plugin for use with logger++, some unintended errors occurred.
I'm using the burp.api.montoya.MontoyaApi version of the API, and when I condition a notes for annotations in handleRequestReceived, I find that my notes are overwritten by logger++. can logger++ not directly overwrite the notes, but instead get a bit of information about the notes from other plugins?

Here is the code

return ProxyRequestReceivedAction.continueWith(httpRequestNew, annotations.withNotes("request1"));

The request1 message I added gets overwritten by the logger++ one.

Steps To Reproduce:

Expected behavior:

Screenshots:

Version:

@17307 17307 added the bug label Aug 8, 2023
@CoreyD97
Copy link
Collaborator

CoreyD97 commented Aug 8, 2023

Unfortunately, the Burp API doesn't provide a way for two plugins to write separate comments to a single HTTP request.

Though, to maintain compatibility, Logger++ should append it's comment to any existing comment set by other tools, then remove the tag once the response has been processed, leaving the original comment intact. As long as L++ is the last plugin in the list, this should be invisible to other apps using the annotations functionality.

@17307
Copy link
Author

17307 commented Aug 8, 2023

Unfortunately, the Burp API doesn't provide a way for two plugins to write separate comments to a single HTTP request.

Though, to maintain compatibility, Logger++ should append it's comment to any existing comment set by other tools, then remove the tag once the response has been processed, leaving the original comment intact. As long as L++ is the last plugin in the list, this should be invisible to other apps using the annotations functionality.

Yes, in the current version even if I put logger++ at the end of the plugin list, my note is still overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants