Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Merge TgSharp.TL with TgSharp.Core #46

Open
aarani opened this issue May 13, 2021 · 2 comments
Open

Discussion: Merge TgSharp.TL with TgSharp.Core #46

aarani opened this issue May 13, 2021 · 2 comments

Comments

@aarani
Copy link

aarani commented May 13, 2021

Currently, we separated the TgSharp to 2 different parts namely "TgSharp.TL" and "TgSharp.Core", there is a side effect to this which is that a lot of functions/properties that should've been internal had to be public to be accessible by TgSharp.Core and caused a lot of confusion for end-users.

Only thing that should be public IMO should be the properties that user should fill or leave empty (if optional). Things like Constructors, SerializeBody and other serialize functions, DeserializeBody and other deserialize functions, Confirmed, NeedConfirmation and etc old transport properties and more so I want to propose merging these two assemblies and making all properties/methods that are not really usable by end-user internal.

P.S: using [InternalsVisibleTo] attribute is a possible solution but I don't know the implications and if it's good solution or not.

@knocte
Copy link
Member

knocte commented May 18, 2021

I think IVT is a good solution.

@aarani
Copy link
Author

aarani commented May 18, 2021

Ok will do this after #41 get merged cause most internal properties are removed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants