Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Enter" on keyboard while on modal forms that don't contain multi-line potential fields (despite not being focused on) should submit the form #322

Open
manfromjupyter opened this issue Oct 10, 2020 · 1 comment
Labels

Comments

@manfromjupyter
Copy link
Contributor

Example: Going to External Resources, creating new external resource, clicking on title field, entering title, clicking on url field, entering url, and then pressing "Enter" on your keyboard should as a shortcut submit the form. At the very least it shouldn't close the modal by pressing that because most sane people might assume it's closing because it succeeded.

Applies to other forms I bet as well, but External Resources is a perfect example because no form contains or can contain a carriage return (no description, no reasoning, or comment field).

@manfromjupyter
Copy link
Contributor Author

Blocked until #639 and #848, else the pressing of the Enter key shouldn't attempt to submit form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant