Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

xBRZ Filter on Canvas #40

Open
MajesticWafer opened this issue Jan 30, 2024 · 7 comments
Open

xBRZ Filter on Canvas #40

MajesticWafer opened this issue Jan 30, 2024 · 7 comments

Comments

@MajesticWafer
Copy link

Heyo! 馃憢

I鈥檝e been experimenting with your website a bit to make it more mobile-friendly [check at https://majesticwafer.github.io/N64Wasm/], and I was trying out an 2xBRZ filter on the canvas. It doesn鈥檛 seem to work, and you obviously have a lot more knowledge about coding than I do, so do you think we could work together to make your and my website more filter- and mobile-friendly?

Best regards,
Wafer

@nbarkhina
Copy link
Owner

I took a quick look at your code, the L and R Shoulder buttons you were updating on the wrong line. I had placeholders for them here in the red arrow just replace those two lines with your code. As for xBRZ i'm not too sure, I've never used that library. I would have to take a deeper look, but it's possible that it only supports getContext('2d') however because its a 3d canvas you need to get a webgl context.

image

@MajesticWafer
Copy link
Author

I鈥檒l take a look at that and see if I can get the L and R buttons to work. I do understand that xBRZ is a pretty bewildering library though 馃槀

@MajesticWafer
Copy link
Author

MajesticWafer commented Jan 31, 2024

I don鈥檛 think it worked, @nbarkhina
IMG_0751
IMG_0752
IMG_0753

EDIT: I think it would be better if I had more knowledge about this

@nbarkhina
Copy link
Owner

I think you just had a bunch of typos see fixes:

image

image

image

@MajesticWafer
Copy link
Author

I have a feeling I鈥檓 doing something wrong. Sorry for bothering you so much just about one thing 馃珷
IMG_0771

@MajesticWafer
Copy link
Author

I applied your changes, but it does not seem to want to work, not quite sure what I鈥檓 doing that is causing the WASM file to not load

@MajesticWafer
Copy link
Author

IMG_0772
IMG_0773
IMG_0774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants