Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Dockerfile #45

Open
kuro96al opened this issue Aug 30, 2023 · 0 comments
Open

Proposed Dockerfile #45

kuro96al opened this issue Aug 30, 2023 · 0 comments

Comments

@kuro96al
Copy link

Hello maintainers and community,

I've noticed that the project doesn't currently have a Dockerfile, so I've taken the initiative to create one. Dockerizing the project provides a consistent environment for both development and deployment, making it easier for contributors to get started and maintain the quality of the project.

What I've Done:

Created a Dockerfile to build and run the project
Tested it locally to ensure that it works as expected

How to Test the Docker Setup:

Build the Docker image: docker build -t [image-name] .
Run the Docker container: docker run [options] [image-name]
Run the splade.all: /opt/conda/envs/splade/bin/python -m splade.all config.checkpoint_dir=experiments/debug/checkpoint config.index_dir=experiments/debug/index config.out_dir=experiments/debug/out

Dockerfile

FROM continuumio/anaconda3:2022.05

RUN git clone https://github.com/naver/splade.git && cd splade
WORKDIR /splade

RUN conda create -n splade_env python=3.9
RUN conda env create -f conda_splade_env.yml

Placement of the Dockerfile:

I've placed the Dockerfile in the project root directory for now, but I'm open to suggestions if there's a more appropriate directory for it.

I would appreciate your feedback on this addition. If it aligns with the project's goals and you find it beneficial, I would be happy to submit a Pull Request.

Thank you for considering my proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant