Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling Depth / Pose for Fine-Tuning #105

Closed
dd2252 opened this issue May 10, 2024 · 2 comments
Closed

Scaling Depth / Pose for Fine-Tuning #105

dd2252 opened this issue May 10, 2024 · 2 comments

Comments

@dd2252
Copy link

dd2252 commented May 10, 2024

Thanks for your great work!

I'm trying to fine-tune the model on non-CO3D data, and was wondering if pose and depth were normalized to some scale. Presumably the scale of CO3D and MegaDepth is somehow normalized so the network can learn. I notice in the code after reading depth CO3D normalizes it:

depthmap = (depthmap.astype(np.float32) / 65535) * np.nan_to_num(input_metadata['maximum_depth'])

I do not see any function applied to translation scale.

Any clarification on what normalization is happening in CO3D, as well as how to apply it to other datasets would be greatly appreciated, thank you!

@dd2252 dd2252 changed the title Scaling Depth / Pose for FineTuning Scaling Depth / Pose for Fine-Tuning May 10, 2024
@yocabon
Copy link
Contributor

yocabon commented May 13, 2024

Hi,
the normalization of the 3d points is done in the criterion. I don't think we do anything at the dataset level.

check https://github.com/naver/dust3r/blob/main/dust3r/losses.py#L177C1-L177C102

@dd2252
Copy link
Author

dd2252 commented May 15, 2024

Thank you!!

@dd2252 dd2252 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants