Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nats Nack missing k8s components. #549

Open
BenCoughlan15 opened this issue Aug 9, 2022 · 2 comments
Open

Nats Nack missing k8s components. #549

BenCoughlan15 opened this issue Aug 9, 2022 · 2 comments

Comments

@BenCoughlan15
Copy link

BenCoughlan15 commented Aug 9, 2022

Hey there!

I've deployed nats-nack, but I can see it's missing the following important components.

RESOURCES:

not that it uses a whole pile, but it would be good to have a handle on this, with sensible defaults.

  • limits.cpu
  • limits.memory
  • requests.cpu
  • requests.memory

PROBES:

pretty important for health checks, etc.

  • livenessProbe
  • readinessProbe

REPLICAS:

ideally more than one, or have a PDB that would ensure its running.

  • replicas

I guess my questions are:

  • Are there any plans to add these?
  • Should I knock together a PR?
  • Is nats-nack still the correct tool to use for account/stream/consumer management?
  • Would you recommend something else?
@wallyqs
Copy link
Member

wallyqs commented Aug 9, 2022

Happy to accept a PR that sets these defaults 👍

@wallyqs
Copy link
Member

wallyqs commented Sep 2, 2022

Since Go 1.19 has been I think we can start adding these limits, we also should apply GOMEMLIMIT so that limits.memory actually works for the Go GC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants