Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert id values from strings to ints #4

Open
nathanhosselton opened this issue Nov 19, 2018 · 4 comments
Open

Convert id values from strings to ints #4

nathanhosselton opened this issue Nov 19, 2018 · 4 comments

Comments

@nathanhosselton
Copy link
Owner

e.g.

DadKit/DadKit/Player.swift

Line 19 in c4cf1d0

internal let membershipId: String

@nathanhosselton nathanhosselton changed the title Conver id values from strings to ints Convert id values from strings to ints Nov 19, 2018
@nathanhosselton
Copy link
Owner Author

  • Don't forget to update the jazzy docs.

@nathanhosselton
Copy link
Owner Author

nathanhosselton commented Dec 3, 2018 •
edited

@b3ll what specific properties are you looking for type conversions on here? I just looked through and I don't even see any that I publicly expose except for on Clan. So I can expose some if you need them, and make them ints.

@b3ll
Copy link
Collaborator

b3ll commented Dec 3, 2018

@nathanhosselton ideally either exposing the membershipID as an Int or making Player, Clan, and Member all conform to Hashable, Equatable, etc so lookups are possible in Collections (see the DataKitExtensions file in Raid Dad)

nathanhosselton added a commit that referenced this issue Dec 3, 2018
@nathanhosselton
Make all public types Equatable, Hashable
3158d37 
Except Clan: Hashable, which is omitted pending a
use case given the implementation requirements.

Refs #4
@nathanhosselton
Copy link
Owner Author

@b3ll Will the changes in that commit fit the bill? Any need to still expose the unique identifiers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b3ll @nathanhosselton