Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make it work with videos inside Github repo? #7

Open
PuneetKohli opened this issue Mar 29, 2020 · 3 comments
Open

How to make it work with videos inside Github repo? #7

PuneetKohli opened this issue Mar 29, 2020 · 3 comments

Comments

@PuneetKohli
Copy link

I want this to work with videos in the github repo but it creates a big black border around the video. Any idea how to fix this?

@nathancy
Copy link
Owner

nathancy commented Apr 2, 2020

This method is only for inserting videos onto Jekyll static webpages. If you're trying to embed videos onto the github repo (as in the README.md), this method will not work. The best alternative workaround I use is to use the screenshot thumbnail image and link it to the actual video. Unfortunately I'm not aware of any method to directly embed the video player onto the README.md page. If you do find a method, please let me know. For the alternative method, look at How can I embed a YouTube video on GitHub wiki pages?

@PuneetKohli
Copy link
Author

PuneetKohli commented Apr 3, 2020

This is for a Jekyll static page. I am trying to use the link to a video which is originally stored in the Repo.

You can see an example here: https://leiainc.github.io/holopix50k/

image

You'll notice a black box around the video. When I use the same html/css for the youtube or google drive links, there is no black box.

edit: This is the link to the video being used https://github.com/LeiaInc/holopix50k/blob/gh-pages/videos/dataset_samples.mp4

@nathancy
Copy link
Owner

I have not found a fix for the black box. The problem may be because your source .mp4 video is a file in the repository. I would recommend just uploading the .mp4 to youtube and following the embed youtube method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants