You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In previous versions of SVG, the ‘href’ attribute was specified in the XLink namespace [xlink] namespace. This usage is now deprecated and instead URL references should be specified using the ‘href’ attribute without a namespace.
What's the expected result?
The href attribute should be used instead.
I can submit a PR, but would you think this is a breaking change although icon visuals remain the same? If you do, I'd like to discuss how we keep compatibility before working on the fix.
What version of
astro-icon
are you using?v1.1.0
Astro Info
If this issue only occurs in one browser, which browser is a problem?
N/A
Describe the Bug
Astro Icon uses the deprecated
xlink:href
attribute and it gives me linting errors.astro-icon/packages/core/components/Icon.astro
Lines 123 to 126 in a4ff873
Below is an excerpt from the relevant part of SVG spec:
What's the expected result?
The
href
attribute should be used instead.I can submit a PR, but would you think this is a breaking change although icon visuals remain the same? If you do, I'd like to discuss how we keep compatibility before working on the fix.
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-vgk3vl?file=src%2Fpages%2Findex.astro
The text was updated successfully, but these errors were encountered: