Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Verbose logging? #166

Open
fflaten opened this issue Dec 24, 2023 · 2 comments
Open

[v1] Verbose logging? #166

fflaten opened this issue Dec 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@fflaten
Copy link

fflaten commented Dec 24, 2023

Consider adding duration astro-icon logs and maybe similar loaded-event for local icons.
Just wasted some time attempting to optimize icon collections because it looked like astro-icon used multiple seconds. In reality it only added 0.5sec.

With astro-icon and components

11:21:06 Types generated 273ms
11:21:06 [build] output: "static"
11:21:06 [build] directory: /workspaces/Website/dist/
11:21:06 [build] Collecting build info...
11:21:06 [build] ✓ Completed in 413ms.
11:21:06 [build] Building static entrypoints...
11:21:11 [astro-icon] Loaded icons from carbon
11:21:13 [build] ✓ Completed in 6.68s.

Without

11:49:55 [build] output: "static"
11:49:55 [build] directory: /workspaces/Website/dist/
11:49:55 [build] Collecting build info...
11:49:55 [build] ✓ Completed in 375ms.
11:49:55 [build] Building static entrypoints...
11:50:01 [build] ✓ Completed in 6.12s.
@natemoo-re natemoo-re added the enhancement New feature or request label Jan 4, 2024
@natemoo-re
Copy link
Owner

I'm not sure if there's much to be done from the integration's side here. Maybe we can update the message itself, but we're only logging once after loading all the icons. The rest is just Astro building the project.

Maybe we should log ✓ Loaded icons in 500ms.?

@fflaten
Copy link
Author

fflaten commented Jan 8, 2024

Maybe we should log ✓ Loaded icons in 500ms.?

Not critical but I'd personally prefer it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants