fix: type generation for local collection #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update ci to use pnpm * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * update lockfile * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: remove Iconify requirement * update lockfile * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs: update core README * chore: update website to use latest code * Remove Sprite references from demo * Swap for correct dependency to install * remove content * update lockfile * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: allow svgo options to be passed * chore(lint): Prettier fix * cleanup merge conflicts --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <nate@astro.build>
* fix build * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* improve error messaging * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* improve readme * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
* fix: prevent failing on missing local collection * chore(lint): Prettier fix --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: e1d8954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stramel
force-pushed
the
ms/fix-type-generation
branch
from
4f7459b
to
8e6d2f8
Compare
* fix: correctly pass svgo options * Create violet-experts-travel.md --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re
force-pushed
the
v1
branch
2 times, most recently
from
f0950f4
to
fceb232
Compare
|
I made very similar changes directly in #111 so I'm going to close this! Thanks for tackling this, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Running
astro checkdoesn't trigger theloadfunction so it currently fails on local collection. We need to add it for the initial run.Separately we need to look into updating the virtual module to handle new icons for local collection.